Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8120579

Minor code clean up in D3D pipe

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Won't Fix
    • Affects Version/s: fx2.0, fx2.0.2
    • Fix Version/s: fx2.1
    • Component/s: javafx
    • Labels:
    • Environment:

      Windows

      Description

      Here is a couple of minor clean up Kirill has suggested:
      1) On C++ side I still have concerns. Statics is inconsistent with other members of D3DPipelineManager. Why all other members are not statics ?
        Other way to not waste memory is: do not hold message and generate it on request (holding temporary buffer on the stack).

      2) Also I`d like to see
          static char messageBuffer[MAX_WARNING_MESSAGE_LEN];
          static char* warningMessage = NULL;
      as a members of D3DPipelineManager and messageBuffer memory allocated dynamically if needed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kprazdnikwse Kirill.Prazdnikov (Inactive)
              Reporter:
              ckyang Chien Yang (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Imported: