Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8123692

TableView editing should be documented better

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 7u21
    • Fix Version/s: 8
    • Component/s: javafx
    • Labels:

      Description

      Even with the tutorial and javadocs, customization for editing values in a TableView can be mysterious.
      Use of setOnEditCommit appears to prevent the default copy of the new value back to the property in the model, it is understandable why this would be done, but this is not documented.
      It's also unclear about what actually happens when calling commitEdit. Implementing a custom editor can be frustrating.
      This is aggravated by bugs and deficiencies in the editing APIs - such as not having an edit commit when the edit control loses focus. That issue is mentioned as a known problem in the tutorial, but the workaround presented there isn't documented well. Is it a *requirement* to customize the commit of an edit by installing a handler with TableColumn.setOnEditCommit whenever you use your own custom cell editor?
      E.g. the docs for commitEdit state "Call this function to transition from an editing state into a non-editing state, and *in the process saving any user input*." - but if a custom handler isn't installed on the column with setOnEditCommit the data may not be saved.

        Attachments

          Activity

            People

            • Assignee:
              jgiles Jonathan Giles
              Reporter:
              swpalmer Scott Palmer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported: