Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8125286

[TreeView] Editing is broken in 8.0

    Details

      Description

      example from:

      package treeview;

      import java.util.Arrays;
      import java.util.List;
      import javafx.application.Application;
      import javafx.event.EventHandler;
      import javafx.scene.Scene;
      import javafx.scene.control.TextField;
      import javafx.scene.control.TreeCell;
      import javafx.scene.control.TreeItem;
      import javafx.scene.control.TreeView;
      import javafx.scene.input.KeyCode;
      import javafx.scene.input.KeyEvent;
      import javafx.scene.paint.Color;
      import javafx.stage.Stage;
      import javafx.util.Callback;

      import javafx.beans.property.SimpleStringProperty;
      import javafx.scene.layout.VBox;

      public class TreeViewSample extends Application {

          List<Employee> employees = Arrays.<Employee>asList(
                  new Employee("Ethan Williams", "Sales Department"),
                  new Employee("Emma Jones", "Sales Department"),
                  new Employee("Michael Brown", "Sales Department"),
                  new Employee("Anna Black", "Sales Department"),
                  new Employee("Rodger York", "Sales Department"),
                  new Employee("Susan Collins", "Sales Department"),
                  new Employee("Mike Graham", "IT Support"),
                  new Employee("Judy Mayer", "IT Support"),
                  new Employee("Gregory Smith", "IT Support"),
                  new Employee("Jacob Smith", "Accounts Department"),
                  new Employee("Isabella Johnson", "Accounts Department"));
          TreeItem<String> rootNode =
                  new TreeItem<String>("MyCompany Human Resources");

          public static void main(String[] args) {
              Application.launch(args);
          }

          @Override
          public void start(Stage stage) {
              rootNode.setExpanded(true);
              for (Employee employee : employees) {
                  TreeItem<String> empLeaf = new TreeItem<String>(employee.getName());
                  boolean found = false;
                  for (TreeItem<String> depNode : rootNode.getChildren()) {
                      if (depNode.getValue().contentEquals(employee.getDepartment())) {
                          depNode.getChildren().add(empLeaf);
                          found = true;
                          break;
                      }
                  }
                  if (!found) {
                      TreeItem<String> depNode = new TreeItem<String>(
                              employee.getDepartment());
                      rootNode.getChildren().add(depNode);
                      depNode.getChildren().add(empLeaf);
                  }
              }

              stage.setTitle("Tree View Sample");
              VBox box = new VBox();
              final Scene scene = new Scene(box, 400, 300);
              scene.setFill(Color.LIGHTGRAY);

              TreeView<String> treeView = new TreeView<String>(rootNode);
              treeView.setEditable(true);
              treeView.setCellFactory(new Callback<TreeView<String>, TreeCell<String>>() {
                  @Override
                  public TreeCell<String> call(TreeView<String> p) {
                      return new TextFieldTreeCellImpl();
                  }
              });

              box.getChildren().add(treeView);
              stage.setScene(scene);
              stage.show();
          }

          private final class TextFieldTreeCellImpl extends TreeCell<String> {

              private TextField textField;

              public TextFieldTreeCellImpl() {
              }

              @Override
              public void startEdit() {
                  super.startEdit();

                  if (textField == null) {
                      createTextField();
                  }
                  setText(null);
                  setGraphic(textField);
                  textField.selectAll();
              }

              @Override
              public void cancelEdit() {
                  super.cancelEdit();
                  setText((String) getItem());
                  setGraphic(getTreeItem().getGraphic());
              }

              @Override
              public void updateItem(String item, boolean empty) {
                  super.updateItem(item, empty);

                  if (empty) {
                      setText(null);
                      setGraphic(null);
                  } else {
                      if (isEditing()) {
                          if (textField != null) {
                              textField.setText(getString());
                          }
                          setText(null);
                          setGraphic(textField);
                      } else {
                          setText(getString());
                          setGraphic(getTreeItem().getGraphic());
                      }
                  }
              }

              private void createTextField() {
                  textField = new TextField(getString());
                  textField.setOnKeyReleased(new EventHandler<KeyEvent>() {
                      @Override
                      public void handle(KeyEvent t) {
                          if (t.getCode() == KeyCode.ENTER) {
                              commitEdit(textField.getText());
                          } else if (t.getCode() == KeyCode.ESCAPE) {
                              cancelEdit();
                          }
                      }
                  });
              }

              private String getString() {
                  return getItem() == null ? "" : getItem().toString();
              }
          }

          public static class Employee {

              private final SimpleStringProperty name;
              private final SimpleStringProperty department;

              private Employee(String name, String department) {
                  this.name = new SimpleStringProperty(name);
                  this.department = new SimpleStringProperty(department);
              }

              public String getName() {
                  return name.get();
              }

              public void setName(String fName) {
                  name.set(fName);
              }

              public String getDepartment() {
                  return department.get();
              }

              public void setDepartment(String fName) {
                  department.set(fName);
              }
          }
      }

        Attachments

          Activity

            People

            • Assignee:
              jgiles Jonathan Giles
              Reporter:
              dzinkevi Dmitry Zinkevich (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:
                Imported: