Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8126594

build script check-native does not check .m files

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 7u6
    • Fix Version/s: 7u6
    • Component/s: javafx
    • Labels:

      Description

      Thor pointed out to me that our build script would not see changes to javafx-font-native/src/MacFontFinder.m
      We needed to perform a clean build everytime that file was changed.

      I tracked the problem down to javafx-font/build.xml check-native
      Here is the one file fix:
      --- a/javafx-font/build.xml Wed May 09 12:03:13 2012 -0700
      +++ b/javafx-font/build.xml Wed May 09 13:43:15 2012 -0700
      @@ -33,7 +33,7 @@
       
         <target name="check-native">
           <uptodate property="native.uptodate" targetfile="${native.dist.dir}/${native.lib.file}" >
      - <srcfiles dir= "${cpp.dir}/src" includes="*.c *.cpp"/>
      + <srcfiles dir= "${cpp.dir}/src" includes="*.c *.cpp *.m"/>
           </uptodate>
         </target>
       
      Felipes-MacBook-Pro

      I also checked (quickly) for other components that could have the same problem, here the list:

      decora-d3d/build.xml: <target name="check-native">
      (check each files individually)

      decora-sse/build.xml: <target name="check-native">
      (only checks for .cc, should check for .h)

      glass/glass-mat-lib-macosx/build.xml: <target name="check-native" depends="init">
      (checks for .m and .h - good)

      javafx-iio/build.xml: <target name="check-native">
      (checks for .c and .h - good)

      prism-d3d/build.xml: <target name="check-native">
      (checks for .cc and .h - good)

      prism-es2/build.xml: <target name="check-native">
      (checks for .c .m .h - good)

      prism-es2n/build.xml: <target name="check-native">
      (check for .c .m, should check for .m)

      prism-sw/build.xml: <target name="check-native">
      (checks for .c .h .inl)

      It seems that decore-sse script is missing decora-sse-native/SSEUtils.h
      and prism-es2n script is missing prism-es2n-native/src/macosx/MacOSXWindowSystemInterface.m


        Attachments

          Activity

            People

            • Assignee:
              fheidric Felipe Heidrich (Inactive)
              Reporter:
              fheidric Felipe Heidrich (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported: