Details

    • Type: Bug
    • Status: Closed
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None

      Description

      As part of JDK-8003853, emit_to_interp_stub sizing was changed from

          start_a_stub(Compile::MAX_stubs_size);

      to

          start_a_stub(to_interp_stub_size()*2);

      In retrospect, it seems better to use

          start_a_stub(to_interp_stub_size());

      and check at the end that the size was big enough, like PPC does:

           assert((__ offset() - offset) <= (int)to_interp_stub_size(), "stub too big");

      or make sure a similar check is part of end_a_stub().

      We also need to make sure Compile::MAX_stubs_size is big enough. If we wanted to make sure it was always big enough, we could change it from an enum to a variable, and do:

      Compile::MAX_stubs_size = MAX(Compile::MAX_stubs_size, to_interp_stub_size());

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dlong Dean Long
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: