Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8134691

CommandLineFlagConstraint::AtParse is not useful and not what we need

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P2
    • Resolution: Withdrawn
    • Affects Version/s: 9
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
      None

      Description

      JDK-8130459 added CommandLineFlagConstraint::AtParse, but it's not quite what we need.

      AtParse denotes that a flag be checked for range/constraint ONLY at parse time, ie. only when the user sets the flag explicitly on command line. It was added to port over the existing runtime flag, but they need to be defined as AfterErgo type, so they get checked during the VM init process.

      Therefore we can safely get rid of AtParse and with some small tweaks get the correct behavior.

        Issue Links

          Activity

          Hide
          gziemski Gerard Ziemski added a comment -
          Now that JEP-243 (JDK-8136421) makes the use of AtParse to ensure that EnableJVMCI is ON if any of the JMCI flags is being attempted to used (clever usage), the cat is out of the bag, and I'm not sure it's worthwhile fixing this and finding another clean mechanism for achieving this behavior. Therefore I am withdrawing this enhancement.
          Show
          gziemski Gerard Ziemski added a comment - Now that JEP-243 ( JDK-8136421 ) makes the use of AtParse to ensure that EnableJVMCI is ON if any of the JMCI flags is being attempted to used (clever usage), the cat is out of the bag, and I'm not sure it's worthwhile fixing this and finding another clean mechanism for achieving this behavior. Therefore I am withdrawing this enhancement.

            People

            • Assignee:
              gziemski Gerard Ziemski
              Reporter:
              gziemski Gerard Ziemski
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: