Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8134985

WebKit build fails with XCode 6.4

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8u60
    • Fix Version/s: 9
    • Component/s: javafx
    • Labels:
    • Environment:

      XCode 6.4

    • Subcomponent:
      web
    • OS:
      os_x

      Backports

        Description

        Release WebKit build fails at link time with the following error:

        Undefined symbols for architecture x86_64:
          "JSC::Structure::putWillGrowOutOfLineStorage()", referenced from:
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(MapConstructor.o)
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(SetConstructor.o)
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(WeakMapConstructor.o)
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(MapIteratorConstructor.o)
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(SetIteratorConstructor.o)
              JSC::JSObject::putDirectWithoutTransition(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int) in libJavaScriptCoreJava.a(ArgumentsIteratorConstructor.o)
              bool JSC::JSObject::putDirectInternal<(JSC::JSObject::PutMode)1>(JSC::VM&, JSC::PropertyName, JSC::JSValue, unsigned int, JSC::PutPropertySlot&, JSC::JSCell*) in libJavaScriptCoreJava.a(JSPromiseFunctions.o)
              ...
        ld: symbol(s) not found for architecture x86_64
        clang: error: linker command failed with exit code 1 (use -v to see invocation)
        make[2]: *** [../lib/libjfxwebkit.dylib] Error 1

        This happens because the JSC::Structure::putWillGrowOutOfLineStorage() is declared in the Structure.h but defined in the StructureInlines.h as inline.
        Unfortunately, the cpp files listed in the error message lacks the recommended #include "JSCInlines.h"

          Issue Links

            Activity

            Hide
            vadim Vadim Pakhnushev (Inactive) added a comment -
            Alexander,
            Could you please review this fix:
            http://cr.openjdk.java.net/~vadim/8134985/webrev.00/index.html
            I cherry-picked from two changesets from the WebKit trunk:
            https://trac.webkit.org/changeset/169703
            https://trac.webkit.org/changeset/168116
            And yes, WeakMapConstructor include is out of order =)
            Show
            vadim Vadim Pakhnushev (Inactive) added a comment - Alexander, Could you please review this fix: http://cr.openjdk.java.net/~vadim/8134985/webrev.00/index.html I cherry-picked from two changesets from the WebKit trunk: https://trac.webkit.org/changeset/169703 https://trac.webkit.org/changeset/168116 And yes, WeakMapConstructor include is out of order =)
            Hide
            azvegint Alexander Zvegintsev added a comment -
            Looks fine to me.
            Show
            azvegint Alexander Zvegintsev added a comment - Looks fine to me.
            Hide
            vadim Vadim Pakhnushev (Inactive) added a comment -
            Changeset: 59e8512b0e83
            Author: vadim
            Date: 2015-09-02 23:36 +0300
            URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/59e8512b0e83
            Show
            vadim Vadim Pakhnushev (Inactive) added a comment - Changeset: 59e8512b0e83 Author: vadim Date: 2015-09-02 23:36 +0300 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/59e8512b0e83

              People

              • Assignee:
                vadim Vadim Pakhnushev (Inactive)
                Reporter:
                vadim Vadim Pakhnushev (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: