Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8134996

GSTREAMER_LITE conditional compilation should be used for all changes in GStreamer

    Details

      Description

      Updated GStreamer has missing GSTREAMER_LITE for some changes.

        Issue Links

          Activity

          Hide
          almatvee Alexander Matveev added a comment -
          http://cr.openjdk.java.net/~almatvee/8134996/webrev.00/

          - Added missing GSTREAMER_LITE.
          - Fixed some white spaces.
          - Fixed line ending for some files.
          - Several files were not merged correctly with latest GStreamer.
          - Deleted several unused files.

          Tested on Windows 32-bit, OS X and Linux 32-bit.
          Show
          almatvee Alexander Matveev added a comment - http://cr.openjdk.java.net/~almatvee/8134996/webrev.00/ - Added missing GSTREAMER_LITE. - Fixed some white spaces. - Fixed line ending for some files. - Several files were not merged correctly with latest GStreamer. - Deleted several unused files. Tested on Windows 32-bit, OS X and Linux 32-bit.
          Hide
          almatvee Alexander Matveev added a comment -
          From Kirill:

          1) Some files have empty diffs: modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/dirent.[h|c]
          modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/wdirent.c
          and some more.

          2) what's the purpose of surrounding in modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gbacktrace.c in GSTREAMER_LITE ? Can we just compile with G_ENABLE_DEBUG if needed ?

          3) modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gutils.c as far as I know we compile with G_DISABLE_DEPRECATED so this code won't be included hence why to change ?

          4) I'm not sure we need these modules/media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-bad/COPYING files I included them long ago without any reason.

          5) Where do we need functions from modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/deprecated/gthread.h ?
          Maybe if it's our code we could rewrite it to make sure we don't use deprecated ghtread at all ?
          Show
          almatvee Alexander Matveev added a comment - From Kirill: 1) Some files have empty diffs: modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/dirent.[h|c] modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/wdirent.c and some more. 2) what's the purpose of surrounding in modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gbacktrace.c in GSTREAMER_LITE ? Can we just compile with G_ENABLE_DEBUG if needed ? 3) modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/gutils.c as far as I know we compile with G_DISABLE_DEPRECATED so this code won't be included hence why to change ? 4) I'm not sure we need these modules/media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-bad/COPYING files I included them long ago without any reason. 5) Where do we need functions from modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/glib/deprecated/gthread.h ? Maybe if it's our code we could rewrite it to make sure we don't use deprecated ghtread at all ?
          Hide
          almatvee Alexander Matveev added a comment -
          1) I changed line ending for these files to original. This is why they show up as empty diffs.
          2) G_ENABLE_DEBUG was added by us, so I put GSTREAMER_LITE.
          3) G_DISABLE_DEPRECATED was added by us, to exclude this code, thus I changed it to GSTREAMER_LITE.
          4) Lets keep them.
          5) We do not used deprecated gthread as far as I know. GLib itself uses it in gthreadprivate.h and we need gthreadprivate.
          Show
          almatvee Alexander Matveev added a comment - 1) I changed line ending for these files to original. This is why they show up as empty diffs. 2) G_ENABLE_DEBUG was added by us, so I put GSTREAMER_LITE. 3) G_DISABLE_DEPRECATED was added by us, to exclude this code, thus I changed it to GSTREAMER_LITE. 4) Lets keep them. 5) We do not used deprecated gthread as far as I know. GLib itself uses it in gthreadprivate.h and we need gthreadprivate.
          Hide
          stayer Kirill Kirichenko (Inactive) added a comment -
          Approved.
          Show
          stayer Kirill Kirichenko (Inactive) added a comment - Approved.
          Show
          almatvee Alexander Matveev added a comment - http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/1853405d2b86

            People

            • Assignee:
              almatvee Alexander Matveev
              Reporter:
              almatvee Alexander Matveev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: