Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8137046

hrt_assert_is_valid should not be a macro

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Won't Fix
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • CPU:
      generic
    • OS:
      generic

      Description

      The macro hrt_assert_is_valid is defined in gc/g1/heapRegionType.hpp.

      Rather than a macro, I suggest it should instead be a private static member function of HeapRegionType, using NOT_DEBUG_RETURN and an ASSERT-only definition in the .cpp file.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kbarrett Kim Barrett
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: