Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8138913

[TESTBUG] hotspot/test/runtime/CommandLine/TestHexArguments.java should not hardcode SharedBaseAddress value

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Won't Fix
    • Affects Version/s: 9
    • Fix Version/s: 11
    • Component/s: hotspot
    • Labels:

      Description

      Followup to JDK-JDK-8078556

      Since we have Dmitry's hotspot/test/runtime/CommandLine/OptionsValidation we should be using that frameworks to dynamically find the range for SharedBaseAddress and use that in the test.

      Currently the test sets SharedBaseAddress=0x1D000000, but with the fix for JDK-8078556 that value will outside the range(2147483648, 18446744073709551615), so for JDK-8078556 I'm going to bump the value up to 0xAD000000. This is again, however, not as robust as it could be if we looked up the range dynamically and figure out the value during the runtime.

      Optionally we could add a feature to hotspot/test/runtime/CommandLine/OptionsValidation to test using HEX values, not just decimal ones. Lastly we could also add another way to pass values by allowing numbers like 100*K or 200*G (the test would have to be smart enough to find a value that fits the range and use K or G to express it) if we decided to add HE values. If we did that, then we wouldn't need the hotspot/test/runtime/CommandLine/TestHexArguments.java test.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gziemski Gerard Ziemski
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: