Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8142874

[TESTBUG] OptionsValidation testing framework needs to handle VM error codes in some cases

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b103

      Description

      SharedReadWriteSize, SharedReadOnlySize, SharedMiscDataSize and SharedMiscCodeSize have default sizes, such that when one of them is set to the MAX, then the VM will exit with error code 2. This registers as a failure in the current framework, but in fact needs to be accepted as success in the cases of these particular flags (ie. failure is defined by a crash that produces error log, not by VM exit with error code)

      TestOptionsWithRanges allows flags to be opted out using:

              allOptionsAsMap.remove("SharedReadWriteSize");

      but it also needs a mechanism that defines allowable exit codes. For most flags that exit code would be implicitly set to 0, but for Shared* it would be 0,2. Perhaps something like:

              allOptionsAsMap.setAllowedExitCodes("SharedReadWriteSize", 0, 2, ...);

      If we had such enhancement, then we could still test the Shared* flags, which at the moment must be disabled.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ddmitriev Dmitry Dmitriev
                Reporter:
                gziemski Gerard Ziemski
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: