Details
Enhancement
P4
Description
The Duration class has no methods to obtain the broken down parts of the duration. This has frustrated users, thus it seems wise to add methods to do this:
- toNanosPart()
- toMillisPart()
- toSecondsPart()
- toMinutesPart()
- toHoursPart()
- toDaysPart()
These would return the breakdown of the duration that is impossible to
access without user-written maths at present.
Given a duration of 49H30M20.123S
- toNanosPart() = 123000000
- toMillisPart() = 123
- toSecondsPart() = 20
- toMinutesPart() = 30
- toHoursPart() = 1
- toDaysPart() = 2
In addition, users have found the lack of a `toSeconds()` method confusing. The method exists, but is named `getSeconds()`, whereas all the similar methods are named `toXxx`. Adding a convenience method here would make the API more usable. Note that this will require renaming an existing private method.
- toNanosPart()
- toMillisPart()
- toSecondsPart()
- toMinutesPart()
- toHoursPart()
- toDaysPart()
These would return the breakdown of the duration that is impossible to
access without user-written maths at present.
Given a duration of 49H30M20.123S
- toNanosPart() = 123000000
- toMillisPart() = 123
- toSecondsPart() = 20
- toMinutesPart() = 30
- toHoursPart() = 1
- toDaysPart() = 2
In addition, users have found the lack of a `toSeconds()` method confusing. The method exists, but is named `getSeconds()`, whereas all the similar methods are named `toXxx`. Adding a convenience method here would make the API more usable. Note that this will require renaming an existing private method.
Issue Links
- relates to
-
JDK-8146489
@since tag missed
-
Activity
Overall, it makes it more consistent:
The toXxx() methods will return the total number of the unit, ignoring smaller units
The toXxxPart() methods will return the relevant "part" of the duration
The getXxx() methods will return the internal state of the object, only second and nano
Note that getNano() and toNanos() are quite different. It just happens that getSecond() and toSecond() end up returning the same thing. Users accessing the internal state will use getXxx(). Users accessing the data who don't care about implementation details will use toXxx() and toXxxPart().
The toXxx() methods will return the total number of the unit, ignoring smaller units
The toXxxPart() methods will return the relevant "part" of the duration
The getXxx() methods will return the internal state of the object, only second and nano
Note that getNano() and toNanos() are quite different. It just happens that getSecond() and toSecond() end up returning the same thing. Users accessing the internal state will use getXxx(). Users accessing the data who don't care about implementation details will use toXxx() and toXxxPart().
Ok. I misunderstood that we are going to replace getSecond() by toSecond(). Now I understood it.
1 more doubt.
Does the method declaration should look like following?
long toNanosPart(String duration);
int toHoursPart(String duration);
1 more doubt.
Does the method declaration should look like following?
long toNanosPart(String duration);
int toHoursPart(String duration);
No, the method looks like this:
int toNanosPart();
int toHoursPart();
and so on.
toNanosPart() returns (nano)
toMillisPart() returns (nano / 1,000,000)
toSecondsPart() returns (second % 60)
toMinutesPart() returns ((second / 60) % 60)
toHoursPart() returns ((second / 3600) % 24)
toDaysPart() returns (second / 86400)
NOTE: these algorithms are psuedo code and probably incorrect for negative durations!
int toNanosPart();
int toHoursPart();
and so on.
toNanosPart() returns (nano)
toMillisPart() returns (nano / 1,000,000)
toSecondsPart() returns (second % 60)
toMinutesPart() returns ((second / 60) % 60)
toHoursPart() returns ((second / 3600) % 24)
toDaysPart() returns (second / 86400)
NOTE: these algorithms are psuedo code and probably incorrect for negative durations!
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 9 [ 14949 ] |
| Status | New [ 10000 ] | Open [ 1 ] |
| Assignee | Roger Riggs [ rriggs ] | Nadeesh Tv [ ntv ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Understanding | Fix Understood [ 10001 ] |
| Summary | Additional java.time.Duration methods | Add java.time.Duration methods for days, hours, minutes, seconds, etc. |
URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f644a5d554a
User: rriggs
Date: 2015-12-09 20:53:14 +0000
User: rriggs
Date: 2015-12-09 20:53:14 +0000
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolved In Build | team [ 17324 ] | |
| Understanding | Fix Understood [ 10001 ] | |
| Resolution | Fixed [ 1 ] |
URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/7f644a5d554a
User: lana
Date: 2015-12-16 19:10:55 +0000
User: lana
Date: 2015-12-16 19:10:55 +0000
| Resolved In Build | team [ 17324 ] | master [ 18256 ] |
| Resolved In Build | master [ 18256 ] | b97 [ 17595 ] |
| Link |
This issue relates to |
| Labels | jsr379-annex2-tbd |
| Labels | jsr379-annex2-tbd | jsr379-annex1 |
| Link | This issue csr of CCC-8142936 [ CCC-8142936 ] |
Since we have both getNano() and toNanos() replacing getSeconds() with toSeconds(), won't it create more confusion?