Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8146566

OpenJDK build can't handle commas in LDFLAGS

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8u65
    • Fix Version/s: 8u92
    • Component/s: infrastructure
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b03

      Backports

        Description

        If additional LDFLAGS containing commas are passed to the build e.g.

        --with-extra-ldflags="-Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common"

        (which are the default flags on Fedora), then the build will fail as the call to SetupNativeCompilation expands LDFLAGS_JDKLIB early and the commas are interpreted to denote separate arguments to this macro.

        On 8, this only affects the demo code (BUILD_DEMO_JVMTI_$1). It also affected the main JDK build on 9 until 8142907 which fixed both cases there. For 8, we should backport the relevant part of 8142907 under this bug.

          Issue Links

            Activity

            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/92c6a16b6dac
            User: andrew
            Date: 2016-01-08 13:54:29 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/92c6a16b6dac User: andrew Date: 2016-01-08 13:54:29 +0000
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/92c6a16b6dac
            User: robm
            Date: 2016-01-15 15:34:17 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/92c6a16b6dac User: robm Date: 2016-01-15 15:34:17 +0000

              People

              • Assignee:
                andrew Andrew Hughes
                Reporter:
                andrew Andrew Hughes
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: