Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8147832 JEP 285: Spin-Wait Hints
  3. JDK-8147844

new method j.l.Thread.onSpinWait() and the corresponding x86 hotspot instrinsic

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b120

      Description

      For details on the java.lang.Thread.onSpinWait() methods refer to the parent task.

      This subtask adds a new method onSpinWait() to java.lang.Thread class with a legitimate implementation that is empty. A corresponding x86 hotspot intrinsic allows to actually benefit from this spin loop hint by injecting a 'pause' instruction into the c2 compiled code.

        Issue Links

          Activity

          Hide
          ikrylov Ivan Krylov added a comment -
          This Webrev passed the code review with core-libs team:
          http://cr.openjdk.java.net/~ikrylov/8147844.jdk.02

          and this webrev passed the code review with the Hotspot team:
          http://cr.openjdk.java.net/~ikrylov/8147844.hs.03
          Show
          ikrylov Ivan Krylov added a comment - This Webrev passed the code review with core-libs team: http://cr.openjdk.java.net/~ikrylov/8147844.jdk.02 and this webrev passed the code review with the Hotspot team: http://cr.openjdk.java.net/~ikrylov/8147844.hs.03
          Hide
          ikrylov Ivan Krylov added a comment -
          The webrevs in Comment #1 were reflecting the proposal of onSpinWint method for the java.lang.Runtime class. The current proposal is to place this method in the Thread class.
          Show
          ikrylov Ivan Krylov added a comment - The webrevs in Comment #1 were reflecting the proposal of onSpinWint method for the java.lang.Runtime class. The current proposal is to place this method in the Thread class.
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/a7aa11177232
          User: psandoz
          Date: 2016-04-06 15:45:23 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/a7aa11177232 User: psandoz Date: 2016-04-06 15:45:23 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/hs-comp/jdk/rev/227c77e44055
          User: psandoz
          Date: 2016-04-06 15:45:27 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/hs-comp/jdk/rev/227c77e44055 User: psandoz Date: 2016-04-06 15:45:27 +0000
          Hide
          ikrylov Ivan Krylov added a comment -
          I still don't see the changeset a7aa11177232 promoted to the main hotspot repository. What kind of valhalla captured this changeset?
          Show
          ikrylov Ivan Krylov added a comment - I still don't see the changeset a7aa11177232 promoted to the main hotspot repository. What kind of valhalla captured this changeset?
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/227c77e44055
          User: lana
          Date: 2016-05-25 17:36:43 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/227c77e44055 User: lana Date: 2016-05-25 17:36:43 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a7aa11177232
          User: lana
          Date: 2016-05-25 17:36:48 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a7aa11177232 User: lana Date: 2016-05-25 17:36:48 +0000

            People

            • Assignee:
              ikrylov Ivan Krylov
              Reporter:
              ikrylov Ivan Krylov
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: