Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8147912

test "parseWithZoneWithoutOffset" of java/time/tck/java/time/format/TCKDTFParsedInstant.java fail on de_DE locale

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: core-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b105

      Description

      Needs to run test cases of java/time/tck/java/time/format/TCKDTFParsedInstant.java against non-English locales for i18n testing.

      The test case "parseWithZoneWithoutOffset" is using below hard code as input data and will fail on de_DE locale.

      Input data in the test:
       @DataProvider(name="parseWithZoneWithoutOffset")
          Object[][] data_parse_WithZone_WithoutOffset() {
              return new Object[][] {
                  {"28 Oct 00:45:00 2012 Europe/Berlin", ZonedDateTime.of(2012, 10, 28, 0, 45, 0, 0, EUROPE_BERLIN)},
                  {"28 Oct 01:45:00 2012 Europe/Berlin", ZonedDateTime.of(2012, 10, 28, 1, 45, 0, 0, EUROPE_BERLIN)},
                  {"28 Oct 02:45:00 2012 Europe/Berlin", ZonedDateTime.of(2012, 10, 28, 2, 45, 0, 0, EUROPE_BERLIN)},
                  {"28 Oct 03:45:00 2012 Europe/Berlin", ZonedDateTime.of(2012, 10, 28, 3, 45, 0, 0, EUROPE_BERLIN)},
                  {"28 Oct 04:45:00 2012 Europe/Berlin", ZonedDateTime.of(2012, 10, 28, 4, 45, 0, 0, EUROPE_BERLIN)},

                  {"28 Oct 01:45:00 2012 Asia/Istanbul", ZonedDateTime.of(2012, 10, 28, 1, 45, 0, 0, ASIA_ISTANBUL)},
                  {"28 Oct 02:45:00 2012 Asia/Istanbul", ZonedDateTime.of(2012, 10, 28, 2, 45, 0, 0, ASIA_ISTANBUL)},
                  {"28 Oct 03:45:00 2012 Asia/Istanbul", ZonedDateTime.of(2012, 10, 28, 3, 45, 0, 0, ASIA_ISTANBUL)},
                  {"28 Oct 04:45:00 2012 Asia/Istanbul", ZonedDateTime.of(2012, 10, 28, 4, 45, 0, 0, ASIA_ISTANBUL)},
                  {"28 Oct 05:45:00 2012 Asia/Istanbul", ZonedDateTime.of(2012, 10, 28, 5, 45, 0, 0, ASIA_ISTANBUL)}
              };
          }

      This is unit testing, so suggest to specify English locale as default locale in test "parseWithZoneWithoutOffset", so that it can pass on non-english locale during i18n testing.
      So suggest change test "parseWithZoneWithoutOffset" as below.
       @Test(dataProvider="parseWithZoneWithoutOffset")
          public void testWithZoneWithoutOffset(String withZoneWithoutOffset, ZonedDateTime expectedZDT) {
              dtFormatter = DateTimeFormatter.ofPattern("d MMM HH:mm:ss uuuu VV").withLocale(Locale.ENGLISH);
              zdt1 = ZonedDateTime.parse(withZoneWithoutOffset, dtFormatter);
              assertEquals(expectedZDT, zdt1);
          }

        Activity

        Hide
        hgupdate HG Updates added a comment -
        URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/094f72523aa4
        User: coffeys
        Date: 2016-02-02 10:45:20 +0000
        Show
        hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/094f72523aa4 User: coffeys Date: 2016-02-02 10:45:20 +0000
        Hide
        hgupdate HG Updates added a comment -
        URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/094f72523aa4
        User: lana
        Date: 2016-02-10 21:55:24 +0000
        Show
        hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/094f72523aa4 User: lana Date: 2016-02-10 21:55:24 +0000

          People

          • Assignee:
            rpatil Ramanand Patil
            Reporter:
            yzhou Daisy Zhou
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: