Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8149468

Incorrect code in jdk.javadoc.internal.doclets.toolkit.util. VisibleMemberMap. ClassMembers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Not an Issue
    • Affects Version/s: 9
    • Fix Version/s: tbd_minor
    • Component/s: tools
    • Labels:

      Description

      Incorrect code in jdk.javadoc.internal.doclets.toolkit.util.VisibleMemberMap.ClassMembers.

      "tagName" variable is compared with strings erroneously prefixed by "@":

      private void checkOnPropertiesTags(List<Element> members) {
      ............................................................................................
                              if (tagName.equals("@propertySetter")
                                      || tagName.equals("@propertyGetter")
                                      || tagName.equals("@propertyDescription")) {
                                  if (!isPropertyGetterOrSetter(members,
      ............................................................................................

      "propertyMethodName" is erroneously suffixed by "Property" making the following comparison senseless:

      private boolean isPropertyGetterOrSetter(List<Element> members,
                                                       ExecutableElement method) {
                  String propertyName = utils.propertyNameFromMethodName(utils.getSimpleName(method));
                  if (!propertyName.isEmpty()) {
                      String propertyMethodName = propertyName + "Property";
                      for (Element member: members) {
                          if (utils.getSimpleName(member).equals(propertyMethodName)) {
                              return true;
                          }
      ............................................................................................

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            ogb Oleg Barbashov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: