Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8149541

Use log_error() instead of log_info() when verification reports a problem

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b108

      Description

      When the GC code was converted to use the unified logging framework the verification logging was changed to mostly use:

      log_info(gc, vefiy)("Information about verification failure");

      The problem with this is that some verification, in particular in G1, does not report the relevant information in asserts and guarnatee messages. Instead the information is logged ahead of time and at some later point there is something like a "guarantee(false, "Verification failed.");"

      So, to know what went wrong you really need the information that was logged. However when it is logged on log_info(gc, verify) you need to have remembered to set -Xlog:gc* on the command line to get this information.

      A better solution is to log failure information at the error level. That way it is always logged.

        Attachments

          Activity

            People

            • Assignee:
              brutisso Bengt Rutisson (Inactive)
              Reporter:
              brutisso Bengt Rutisson (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: