Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8151003

Remove nds->is_valid() checks from assembler_x86.cpp

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b115
    • CPU:
      x86

      Description

      In a number of vector related instruction encoders in assembler_x86.cpp we check the validity of the "nds" argument, and fall back to encoding a zero if it is invalid. This appears to be a copy/paste error and should be fixed. As an example we have this in Assembler::vinsertf32x4h:

      int nds_enc = nds->is_valid() ? nds->encoding() : 0;

      But nds must always be a valid register, and if it's not then encoding a zero will not improve the situation.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mcberg Michael Berg
                Reporter:
                mikael Mikael Vidstedt
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: