Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8151602

Remove logging from refillLinearAllocBlockIfNeeded()

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b115

      Description

      In CompactibleFreeListSpace::refillLinearAllocBlockIfNeeded() we have this code:

        if (PrintMiscellaneous && Verbose) {
          if (blk->_word_size == 0) {
            warning("CompactibleFreeListSpace(prologue):: Linear allocation failure");
          }

      It is a bit strange to guard a warning() this way. Verbose is a develop flag so the warning is never printed in product builds. This is also the only use of PrintMiscellaneous in the GC code.

      Another strange thing about this logging is that is says "(prologue)" but refillLinearAllocBlockIfNeeded() is called from three places:

      CompactibleFreeListSpace::gc_prologue()
      CompactibleFreeListSpace::reset_after_compaction()
      CompactibleFreeListSpace::sweep_completed()

        Attachments

          Activity

            People

            • Assignee:
              brutisso Bengt Rutisson (Inactive)
              Reporter:
              brutisso Bengt Rutisson (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: