Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8152356

Change to -Xshare:auto for 32-bit platforms

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P3
    • Resolution: Won't Fix
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:

      Description

      The following #ifdef block should be removed. The comments in there is no longer correct.

      After JDK-8074345, bytecode rewriting is enabled for non-shared classes. So CDS should no longer affect the performance of benchmarks executed by C2.

      ----------
      void Arguments::set_ergonomics_flags() {
        select_gc();

      #if defined(COMPILER2) || INCLUDE_JVMCI
        // Shared spaces work fine with other GCs but causes bytecode rewriting
        // to be disabled, which hurts interpreter performance and decreases
        // server performance. When -server is specified, keep the default off
        // unless it is asked for. Future work: either add bytecode rewriting
        // at link time, or rewrite bytecodes in non-shared methods.
        if (!DumpSharedSpaces && !RequireSharedSpaces &&
            (FLAG_IS_DEFAULT(UseSharedSpaces) || !UseSharedSpaces)) {
          no_shared_spaces("COMPILER2 default: -Xshare:auto | off, have to manually setup to on.");
        }
      #endif
      ------------

        Attachments

          Issue Links

          There are no Sub-Tasks for this issue.

            Activity

              People

              • Assignee:
                ccheung Calvin Cheung
                Reporter:
                iklam Ioi Lam
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved: