Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8154529

some places in the invoke.c that use InvokeRequest* not protected with invokerLock

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: core-svc
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b120
    • CPU:
      generic
    • OS:
      generic

      Description

      It seems, the invokerLock is to protect any uses of the 'request' pointer that points to the field ThreadNode.currentInvoke, not to protect the saveGlobalRef() call itself. So that, we have a hole in synchronization that was nicely discovered by Severin G in the fix for bug:
        https://bugs.openjdk.java.net/browse/JDK-8153711

      Here are more places where the 'request' pointer is not protected with the invokerLock:
          invoker_enableInvokeRequests()
          invoker_isPending()
          invoker_isEnabled().

      In general, these are pretty simple or rare cases that do not harm much.
      The function invoker_isPending() is not used at all.

        Issue Links

          Activity

          Hide
          sgehwolf Severin Gehwolf added a comment -
          invoker_isPending() seems unused.
          Show
          sgehwolf Severin Gehwolf added a comment - invoker_isPending() seems unused.
          Show
          sgehwolf Severin Gehwolf added a comment - Posted for review: http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-April/019518.html
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/hs/jdk/rev/c43aba5fc69b
          User: sspitsyn
          Date: 2016-05-08 09:38:42 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/hs/jdk/rev/c43aba5fc69b User: sspitsyn Date: 2016-05-08 09:38:42 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c43aba5fc69b
          User: lana
          Date: 2016-05-25 17:36:43 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c43aba5fc69b User: lana Date: 2016-05-25 17:36:43 +0000

            People

            • Assignee:
              sgehwolf Severin Gehwolf
              Reporter:
              sspitsyn Serguei Spitsyn
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: