Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: javafx
    • Labels:

      Description


      Investigate if we can auto detect any GTK version in use before loading GTK in JFX.

        Issue Links

          Activity

          Hide
          kcr Kevin Rushforth added a comment -
          The logic looks good. Testing looks good. Two comments on the code itself:

          1. There is an unconditional call to "fflush(stdout)" that needs to be qualified by gtk_versionDebug (or simply moved to right after the printf in the for loop, since performance isn't a concern in this case).


          2. Minor nit: There should be a space after the "for" and before the "(" in:

          for(i = 0; use_chain[i] && !found; i++) {


          +1 pending the fixes above (no need for a new webrev if those are the only changes).
          Show
          kcr Kevin Rushforth added a comment - The logic looks good. Testing looks good. Two comments on the code itself: 1. There is an unconditional call to "fflush(stdout)" that needs to be qualified by gtk_versionDebug (or simply moved to right after the printf in the for loop, since performance isn't a concern in this case). 2. Minor nit: There should be a space after the "for" and before the "(" in: for(i = 0; use_chain[i] && !found; i++) { +1 pending the fixes above (no need for a new webrev if those are the only changes).
          Show
          ssadetsky Semyon Sadetsky added a comment - http://cr.openjdk.java.net/~ssadetsky/8156491/webrev.02/
          Hide
          kcr Kevin Rushforth added a comment -
          Thanks, looks good.
          Show
          kcr Kevin Rushforth added a comment - Thanks, looks good.
          Hide
          ssadetsky Semyon Sadetsky added a comment -
          Could you, please, push it?
          Show
          ssadetsky Semyon Sadetsky added a comment - Could you, please, push it?
          Hide
          ddhill David Hill (Inactive) added a comment -
          Changeset: 4d72bb1f6d81
          Author: ssadetsky
          Date: 2016-12-22 13:16 -0500
          URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4d72bb1f6d81

          8156491: Autodetect GTK version for JFX
          Reviewed-by: ddhill, kcr

          ! modules/javafx.graphics/src/main/native-glass/gtk/launcher.c
          Show
          ddhill David Hill (Inactive) added a comment - Changeset: 4d72bb1f6d81 Author: ssadetsky Date: 2016-12-22 13:16 -0500 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4d72bb1f6d81 8156491: Autodetect GTK version for JFX Reviewed-by: ddhill, kcr ! modules/javafx.graphics/src/main/native-glass/gtk/launcher.c

            People

            • Assignee:
              ssadetsky Semyon Sadetsky
              Reporter:
              ddhill David Hill (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: