Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8156498

more places in the invoke.c that need protection with the invokerLock

    Details

    • Type: Enhancement
    • Status: Open
    • Priority: P4
    • Resolution: Unresolved
    • Affects Version/s: 9
    • Fix Version/s: 11
    • Component/s: core-svc
    • Labels:
      None
    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      This is a fragment from my review of the fix:
        8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

      A couple of questions...

      It seems, there are more places where an invokerLock critical section is missed.
      The following functions:
        - invokeConstructor
        - invokeStatic
        - invokeNonvirtual
        - invokeVirtual
        - saveGlobalRef

      The first function is easy to fix.
      The last 5 functions are called from the invoker_doInvoke() that we already had a problem with.

        Issue Links

          Activity

          Hide
          sgehwolf Severin Gehwolf added a comment -
          I believe invoker_enableInvokeRequest has been fixed with JDK-8154529.
          Show
          sgehwolf Severin Gehwolf added a comment - I believe invoker_enableInvokeRequest has been fixed with JDK-8154529 .
          Hide
          sspitsyn Serguei Spitsyn added a comment -
          [ @Severin ]
          Agreed. Removed the invoker_enableInvokeRequest from the description list.
          Show
          sspitsyn Serguei Spitsyn added a comment - [ @Severin ] Agreed. Removed the invoker_enableInvokeRequest from the description list.
          Hide
          sspitsyn Serguei Spitsyn added a comment -
          Retargeting this to 11 as we have never observed this issue with our tests/nightly yet.
          Show
          sspitsyn Serguei Spitsyn added a comment - Retargeting this to 11 as we have never observed this issue with our tests/nightly yet.

            People

            • Assignee:
              Unassigned
              Reporter:
              sspitsyn Serguei Spitsyn
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: