Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: infrastructure
    • Labels:
      None

      Description

      With the repository consolidated (JDK-8165183), it makes sense to reorganize the test as follows: for each of the existing test directories

          $OPENJDK/hotspot/test
          $OPENJDK/jaxp/test
          $OPENJDK/jdk/test
          $OPENJDK/langtools/test/
          $OPENJDK/nashorn/test

      move those directories under a single

          $OPENJDK/test

      directory to result in


          $OPENJDK/test/hotspot
          $OPENJDK/test/jdk
          ...

      Either as part of this bug or as a separate issue, the TEST.ROOT and TEST.groups files from those directories can be combined.

        Issue Links

          Activity

          Hide
          jjg Jonathan Gibbons added a comment -
          Understood: I'm just pointing out the consequences of not moving towards a consistent overall organization for tests.
          Show
          jjg Jonathan Gibbons added a comment - Understood: I'm just pointing out the consequences of not moving towards a consistent overall organization for tests.
          Hide
          dholmes David Holmes added a comment -
          Such a proposal would also require further discussion. Different components use different frameworks. I much prefer the ability to run any combination of component tests from one directory ie hotspot.
          Show
          dholmes David Holmes added a comment - Such a proposal would also require further discussion. Different components use different frameworks. I much prefer the ability to run any combination of component tests from one directory ie hotspot.
          Hide
          jjg Jonathan Gibbons added a comment -
          If we are not going to merge the jdk and hotspot test directories, it is not worth merging any other combinations.

          If you're still thinking to have a single test directory for jtreg, with a TEST.ROOT in test/TEST.ROOT, I would recommend an update to jtreg to allow it to ignore test/gtest.

          Show
          jjg Jonathan Gibbons added a comment - If we are not going to merge the jdk and hotspot test directories, it is not worth merging any other combinations. If you're still thinking to have a single test directory for jtreg, with a TEST.ROOT in test/TEST.ROOT, I would recommend an update to jtreg to allow it to ignore test/gtest.
          Hide
          erikj Erik Joelsson added a comment -
          That is an interesting proposal, but we are out of time for that kind of change at this point unless we want to delay the consolidation.
          Show
          erikj Erik Joelsson added a comment - That is an interesting proposal, but we are out of time for that kind of change at this point unless we want to delay the consolidation.
          Hide
          jjg Jonathan Gibbons added a comment -
          [~erikj] Re: the preceding comment:

          If we really mean to consolidate the test directories, how about

              test/
                  jtreg/
                      hotspot/
                      jdk/
                      langtools/
                  gtest/

          In other words, use
              test / <framework> / <historical-group>
          Show
          jjg Jonathan Gibbons added a comment - [~erikj] Re: the preceding comment: If we really mean to consolidate the test directories, how about     test/         jtreg/             hotspot/             jdk/             langtools/         gtest/ In other words, use     test / <framework> / <historical-group>

            People

            • Assignee:
              erikj Erik Joelsson
              Reporter:
              darcy Joe Darcy
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: