Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8166651

OrderAccess::load_acquire &etc should have const parameters

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b21
    • CPU:
      generic
    • OS:
      generic

      Description

      The signatures for the various OrderAccess::load_acquire overloads are presently of the form

        T load_acquire(volatile T* p);

      It seems like that should be

        T load_acquire(const volatile T* p);

      Similarly for load_ptr_acquire (note that there are presently two overloads for load_ptr_acquire for void*, one const-qualified, and one not. The non-const-qualified overfload should be removed.

      Similarly for Atomic::load(volatile jlong*).

        Attachments

          Activity

            People

            • Assignee:
              kbarrett Kim Barrett
              Reporter:
              kbarrett Kim Barrett
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: