Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8168023

Problems with BlockedException thrown from SecureStaticVersioning

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: deploy
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b144

      Description

      The code in both SecureStaticVersioning in methods ShowSSV2Dialog() and showCannotUseDialog throws a BlockedException, there are two problems with this exception:
      1.) it constructs exception with the "key" argument "deployment.blocked.cancel", and there is no such resource in Deployment.java
      2.) it throws a BlockedException, which previously just exited, but after code change to show the Blocked Dialog after getting back into Plugin2Manager, it will show a blocked dialog.

      In these cases - and I need to check for any more such cases - the BlockedException is thrown without calling ShowBlockedDialog because the user has already seen a dialog and declined to run (in one case) or told he cannot (in the other) - so we have to differentiate between BlockedException that may need to be later shown, and those that don't.

      Even without the dialog the resource for the string "deployment.blocked.cancel" should have been shown in trace output instead of the key that is shown now (since there is no such resource).

        Attachments

          Activity

            People

            • Assignee:
              herrick Andy Herrick
              Reporter:
              herrick Andy Herrick
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: