Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8168821

Cleanup whitespace after fix for JDK-8156078

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 8u152
    • Fix Version/s: 8u152
    • Component/s: javafx
    • Subcomponent:
    • Resolved In Build:
      b01
    • Verification:
      Verified

      Description

      The checkWhiteSpace script fails after the fix for JDK-8156078:

      $ bash tools/scripts/checkWhiteSpace -a
      modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java :trailingWhitespace:


      Found 1 whitespace or executable issues

      To correct, use
         bash ./tools/scripts/checkWhiteSpace -F -a

        Issue Links

          Activity

          Hide
          ckyang Chien Yang (Inactive) added a comment -
          Please review the following simple fix:

          diff --git a/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java b/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
          --- a/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
          +++ b/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
          @@ -559,7 +559,7 @@
               public void setAlwaysOnTop(boolean alwaysOnTop) {
                   // The securityDialog flag takes precedence over alwaysOnTop
                   if (securityDialog) return;
          -
          +
                   if (isAlwaysOnTop == alwaysOnTop) {
                       return;
                   }
          Show
          ckyang Chien Yang (Inactive) added a comment - Please review the following simple fix: diff --git a/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java b/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java --- a/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java +++ b/modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java @@ -559,7 +559,7 @@      public void setAlwaysOnTop(boolean alwaysOnTop) {          // The securityDialog flag takes precedence over alwaysOnTop          if (securityDialog) return; - +          if (isAlwaysOnTop == alwaysOnTop) {              return;          }
          Hide
          kcr Kevin Rushforth added a comment -
          +1
          Show
          kcr Kevin Rushforth added a comment - +1
          Hide
          ckyang Chien Yang (Inactive) added a comment -
          Changeset: e76f5a8d6fc4
          Author: ckyang
          Date: 2016-10-27 09:29 -0700
          URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e76f5a8d6fc4
          Show
          ckyang Chien Yang (Inactive) added a comment - Changeset: e76f5a8d6fc4 Author: ckyang Date: 2016-10-27 09:29 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e76f5a8d6fc4

            People

            • Assignee:
              ckyang Chien Yang (Inactive)
              Reporter:
              kcr Kevin Rushforth
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: