Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8170024

PiscesRenderer.pr.emitAndClearAlphaRow cannot accept a pix_x_from parameter greater than clip.xmin

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9, 10
    • Fix Version/s: 10
    • Component/s: javafx
    • Labels:

      Description

      These comments are from the new Marlin AlphaConsumer used for filling shapes in the SW pipeline:

       236 // use x instead of pix_from as it cause artefacts:
       237 // note: it would be more efficient to skip all those empty pixels [x to pix_from[
       238 // but the native implementation must be fixed too.
       239 // pr.emitAndClearAlphaRow(alpha_map, alphaDeltas, pix_y, pix_from, pix_to, rowNum);
       240 pr.emitAndClearAlphaRow(alpha_map, alphaDeltas, pix_y, x, pix_to, rowNum);

      As a result, all pixels from the left edge of the clip to the start of the shape must be processed even though we know that they are all 0-alpha coverage. This likely has a large performance drain on the SW pipeline.

        Attachments

          Activity

            People

            • Assignee:
              lbourges Laurent Bourg├Ęs
              Reporter:
              flar Jim Graham
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: