Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8172213

Remove unused and partially implemented JavacElements#getSourcePosition methods

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: tools
    • Subcomponent:
    • Resolved In Build:
      b153
    • Verification:
      Not verified

      Description

      JavacSourcePosition's documentation says: "Implementation of model API SourcePosition based on javac internal state." That model API class does not exist, and the methods are never used in javac. They can be removed.

      `getSourcePosition(Element, AnnotationMirror, AnnotationValue)` was never implemented, and has a matching TODO to `getTreeAndTopLevel(Element, AnnotationMirror, AnnotationValue) ` (see JDK-6388543).

        Issue Links

          Activity

          Hide
          jjg Jonathan Gibbons added a comment -
          The direct use of JavaFileObject::toString, as compared to JavaFileObject::getName is also troubling.
          Show
          jjg Jonathan Gibbons added a comment - The direct use of JavaFileObject::toString, as compared to JavaFileObject::getName is also troubling.
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/b95622ea8356
          User: vromero
          Date: 2017-01-12 17:19:26 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/b95622ea8356 User: vromero Date: 2017-01-12 17:19:26 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/b95622ea8356
          User: lana
          Date: 2017-01-18 22:12:53 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/b95622ea8356 User: lana Date: 2017-01-18 22:12:53 +0000

            People

            • Assignee:
              vromero Vicente Arturo Romero Zaldivar
              Reporter:
              cushon Liam Miller-Cushon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: