Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8173581

performance regression in com/sun/crypto/provider/OutputFeedback.java

    Details

    • Subcomponent:
    • Resolved In Build:
      b155
    • Verification:
      Not verified

      Backports

        Description

        The fix for JDK-8049312 refactored OutputFeedback.encrypt(). See http://hg.openjdk.java.net/jdk9/dev/jdk/rev/09bcd51adf34 .

        The changset was backported to jdk8u as part of 8u111/8u112 in
        http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/b760ad429561 .

        At Google, we've noticed a performance regression on a production server using 8u112 due to this change, which can simply observed on a desktop by a 10-15% speed reduction in the jtreg test test/com/sun/crypto/provider/Cipher/AES/CICO.java.

        Looking at the refactoring in OutputFeedback.encrypt(), two calls to System.arraycopy() have moved from the outer loop to the inner, where they are invariant. The revised code is still semantically correct, but unintentionally performs poorly. The two calls (and the guard) should be moved to the outer loop.

        I hope to provide a webrev with a fix shortly.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  valeriep Valerie Peng
                  Reporter:
                  rasbold Chuck Rasbold
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Due:
                    Created:
                    Updated:
                    Resolved: