Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8174944

Generate bss for all css files, remove TODO

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8, 9
    • Fix Version/s: 10
    • Component/s: javafx
    • Labels:

      Description

      There is a lingering set of questions in build.gradle.

          // TODO Css2Bin really should be moved out and put into buildSrc if it can be
          // TODO could change script to dynamically locate all .css files and create bss for them, probably better
          // TODO also not sure there is any benefit to having css files in the the runtime modules at all

      Should we be shipping css2bin and the css files ?

      This also raises the question - should we be shipping bss for all 15 of the css files in controls resources (currently we convert 9 of them).

      If don't need the css2bin, then we would want to move it to a different sourceSet in controls.

      If we don't need the .css files, we would move them to a different location (not main/resources). Then we could have a task to convert the css to bss. We would likely use a file tree to discover the files to be converted. Then a set of copy tasks to copy the bss to the normal and shims output trees.

      This change should probably be considered early in a release.

        Attachments

          Activity

            People

            • Assignee:
              ddhill David Hill (Inactive)
              Reporter:
              ddhill David Hill (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: