Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8175554

Improve G1UpdateRSOrPushRefClosure

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9, 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b21

      Description

      After JDK-8071278 some additional (micro-)optimizations for G1UpdateRSOrPushRefClosure became apparent:

      - use the oopDesc::load_heap_oop without decoding for the null check
      - one can do the crosses-region check without accessing the heap region
      - it's probably better to use the in_cset_state for checking whether something is in the collection set instead of referencing the HeapRegion*
      - the same null check and is-in-cset check is repeated in the called G1ParPushHeapRSClosure
      - we should not optimize for evacuation failure in this closure, i.e. try to minimize the number of cards to rescan in evacuation failure occurs.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tschatzl Thomas Schatzl
              Reporter:
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: