Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8176362

Improve code quality of StarTask

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Not an Issue
    • Affects Version/s: 9, 10
    • Fix Version/s: tbd
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc

      Description

      While adding a similar class as StarTask for tagging LSBs of elements in task queue called G1TaskQueueEntry in JDK-8168467, we noticed several code quality related issues.

      - need for a define to suppress MSVC warnings due to two assignment operator overloads (still pending discussion)
      - copy-assign w/o copy-construct (which is often considered a bad smell)
      - implicit conversions from oop/narrowoop using the constructors

      Look into fixing this and potentially also trying to reuse code for both in some way.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: