Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8176402

parameter name switcharoo in ConcurrentHashMap

    Details

      Description

      As discovered by a new errorprone check (by examining corresponding constructor parameter names) that the order of constructor parameters in some CHM classes was inadvertently switched. But this mistake was benign, because the using classes simply called super with the wrong order - here 2 wrongs made a right. But needs fixing anyways.

        Activity

        Show
        martin Martin Buchholz added a comment - http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ConcurrentHashMap/
        Hide
        chegar Chris Hegarty added a comment -
        This looks fine Martin. The mistake is more obvious in a recent IntelliJ version where param names show up at the call sites, so it appears that size is always 0 for KeyIterator in CHM::keys !!
        Show
        chegar Chris Hegarty added a comment - This looks fine Martin. The mistake is more obvious in a recent IntelliJ version where param names show up at the call sites, so it appears that size is always 0 for KeyIterator in CHM::keys !!
        Hide
        hgupdate HG Updates added a comment -
        URL: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/1f0fb30f5279
        User: martin
        Date: 2017-04-10 21:15:01 +0000
        Show
        hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/1f0fb30f5279 User: martin Date: 2017-04-10 21:15:01 +0000

          People

          • Assignee:
            martin Martin Buchholz
            Reporter:
            martin Martin Buchholz
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: