Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8176402

parameter name switcharoo in ConcurrentHashMap

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: core-libs
    • Labels:

      Description

      As discovered by a new errorprone check (by examining corresponding constructor parameter names) that the order of constructor parameters in some CHM classes was inadvertently switched. But this mistake was benign, because the using classes simply called super with the wrong order - here 2 wrongs made a right. But needs fixing anyways.

        Activity

        martin Martin Buchholz created issue -
        martin Martin Buchholz made changes -
        Field Original Value New Value
        Status New [ 10000 ] Open [ 1 ]
        martin Martin Buchholz made changes -
        Labels noreg-cleanup
        martin Martin Buchholz made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Understanding Fix Understood [ 10001 ]
        martin Martin Buchholz made changes -
        Summary argument switcharoo in ConcurrentHashMap parameter name switcharoo in ConcurrentHashMap
        martin Martin Buchholz made changes -
        Fix Version/s 10 [ 16302 ]
        Show
        martin Martin Buchholz added a comment - http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ConcurrentHashMap/
        chegar Chris Hegarty made changes -
        Affects Version/s 10 [ 16302 ]
        Hide
        chegar Chris Hegarty added a comment -
        This looks fine Martin. The mistake is more obvious in a recent IntelliJ version where param names show up at the call sites, so it appears that size is always 0 for KeyIterator in CHM::keys !!
        Show
        chegar Chris Hegarty added a comment - This looks fine Martin. The mistake is more obvious in a recent IntelliJ version where param names show up at the call sites, so it appears that size is always 0 for KeyIterator in CHM::keys !!
        martin Martin Buchholz made changes -
        Fix Version/s 9 [ 14949 ]
        Fix Version/s 10 [ 16302 ]
        martin Martin Buchholz made changes -
        Fix Version/s 10 [ 16302 ]
        Fix Version/s 9 [ 14949 ]
        Hide
        hgupdate HG Updates added a comment -
        URL: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/1f0fb30f5279
        User: martin
        Date: 2017-04-10 21:15:01 +0000
        Show
        hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/1f0fb30f5279 User: martin Date: 2017-04-10 21:15:01 +0000
        hgupdate HG Updates made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolved In Build master [ 18256 ]
        Understanding Fix Understood [ 10001 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            martin Martin Buchholz
            Reporter:
            martin Martin Buchholz
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: