Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8176580

[ppc, s390] CRC32C: wrong checksum result in some cases

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Subcomponent:
    • Introduced In Version:
      10
    • Resolved In Build:
      b21
    • CPU:
      ppc, s390x
    • OS:
      generic

      Description

      The newly introduced CRC32C intrinsics unfortunately calculate a bad checksum, if
       * the passed-in byte array has an offset != 0
       * the intrinsic implementation is called via the interpreter or via a c1-compiled method.

      Reason:
      in contrast to the CRC32 intrinsics, the CRC32C intrinsics receive an end-index parameter instead of a length parameter. The length has to be calculated by the intrinsic as (endIndex - offset). This subtraction was simply forgotten.

        Issue Links

          Activity

          Hide
          zmajo Zoltan Majo (Inactive) added a comment -
          ILW=incorrect results generated, programs on ppc using the CRC32C implementation, disable CRC32C intrinsic=HHL=P2
          Show
          zmajo Zoltan Majo (Inactive) added a comment - ILW=incorrect results generated, programs on ppc using the CRC32C implementation, disable CRC32C intrinsic=HHL=P2
          Hide
          lucy Lucy Schmidt added a comment -
          Fix is (almost) ready, currently testing internally. Will create a webrev/RFR on Tuesday am (CET).
          Show
          lucy Lucy Schmidt added a comment - Fix is (almost) ready, currently testing internally. Will create a webrev/RFR on Tuesday am (CET).
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/6abbd10800bc
          User: simonis
          Date: 2017-04-18 15:50:16 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/6abbd10800bc User: simonis Date: 2017-04-18 15:50:16 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/6abbd10800bc
          User: jwilhelm
          Date: 2017-08-18 18:01:35 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/6abbd10800bc User: jwilhelm Date: 2017-08-18 18:01:35 +0000

            People

            • Assignee:
              lucy Lucy Schmidt
              Reporter:
              lucy Lucy Schmidt
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: