Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8178013

Finetuning of merged tab and shift tab completion

    Details

    • Subcomponent:
    • Resolved In Build:
      b165
    • Verification:
      Verified

      Backports

        Description

        From:
        http://mail.openjdk.java.net/pipermail/kulla-dev/2017-March/001978.html

        A couple of comments (on webrev.03) [of JDK-8177076]:

        This help string has the wrong whitespace:

        + a variable declaration whose type is based on the type of the expression.\n\t\t\
        +Shift-<tab> i\n\t\t\

        The first \n\t\t\ should be \n\n.

        Help strings should not mention <fix> anymore:

        +Invalid <fix> character. Use "i" for auto-import or "v" for variable creation. For more information see:\n\
        + /help shortcuts

        I suggest: Unexpected character after Shift-Tab. Use "i" …

        I built your patch and tried it out. I like the new behavior very much.
        The "Shift-Tab i" command is more friendly.

        Thanks!

        I noticed a couple of oddities.

        First of all, "/help /set <Tab>" prints the "/set" subcommands, but "/help set <Tab>" does not.

        jshell> /help /set <Tab>
        editor feedback format mode prompt start truncation
        jshell> /help set <Tab>
        get information about jshell <==== YES, I THOUGHT I WAS DOING THAT?

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jlahoda Jan Lahoda
                  Reporter:
                  jlahoda Jan Lahoda
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: