Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8178363

Incorrect check for nmethod re-registration in C1

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b21

      Description

      When an nmethod is compiled, it's registered with the heap if ScavengeRootsInCode is non-zero (which it always is). However, during code patching in C1 we re-register the nmethod with the heap only if it also has scavengable oops. This additional requirement is only valid for calls to CodeCache::add_scavenge_root_nmethod(), and not for CollectedHeap::register_nmethod(). This happens to work today since G1's is_scavengable() basically always returns true.

        Attachments

          Activity

            People

            Assignee:
            pliden Per Liden
            Reporter:
            pliden Per Liden
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: