Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8184323

compile-time guard some UseSharedSpaces-only coding with the INCLUDE_CDS macro

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b21
    • CPU:
      generic
    • OS:
      generic

      Description

      When looking into CDS related build options, I noticed that most code-parts that are executed only when UseSharedSpaces is set,
      are guarded by the compile-time macro INCLUDE_CDS to support switching off compilation of this coding in case CDS is disabled at compile time , see

       hotspot/make/lib/JvmFeatures.gmk :

       ifneq ($(call check-jvm-feature, cds), true)
        JVM_CFLAGS_FEATURES += -DINCLUDE_CDS=0

      However some places miss the compile-time guarding.

        Attachments

          Activity

            People

            • Assignee:
              mbaesken Matthias Baesken
              Reporter:
              mbaesken Matthias Baesken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: