Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8184800

Streamline RTM flag validity testing with generic flag testing support

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b21
    • CPU:
      x86, ppc

      Description

      RTM was implemented before specifying ranges for flags was established
      in openJdk. It has custom checks implemented per platform in
      vm_version_<cpu>.cpp as well as tests for these checks in compiler/rtm/cli.

      8180612 added ranges for a row of RTM flags. Tests for RTMAbortRation
      and RTMTotalCountIncrRate now fail, because the range check failure
      message is different.

      This change removes the custom checks, implements a generic method
      RTMTotalCountIncrRateConstraintFunc() and updates the tests. Some
      tests are now superfluous as the ranges will be tested by
      TestOptionsWithRanges.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                goetz Goetz Lindenmaier
                Reporter:
                goetz Goetz Lindenmaier
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: