Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8186236

ModuleInfoExtender should be ASM6 aware

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: core-libs
    • Labels:

      Description

      The ModuleInfoExtender was a facility to add ModuleAttributes using ASM5.
      ASM5 is pre-modules based implementation. However, ASM6 now supports
      specified module attributes inherently, and the ModuleInfoExtender must be
      adapted to use ASM6.

      http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/74776ebdab24/src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java

      The Attributest are being defined here:
      http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/74776ebdab24/src/java.base/share/classes/jdk/internal/module/ClassFileAttributes.java

      The latest ASM6 patch adapted to the JDK is attached.

      It is likely jlink will also need some re-factoring and adjustments.

      Not doing so will not allow JDK's internal version of ASM, to be updated.

        Attachments

        1. asm6.patch
          266 kB
          Kumar Srinivasan

          Issue Links

            Activity

              People

              Assignee:
              alanb Alan Bateman
              Reporter:
              ksrini Kumar Srinivasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: