Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8186736

Spec clarifications for IllegalArgumentException throwing - ModuleLayer.defineX methods

    Details

      Description

      #1 Specification for the following method

      ModuleLayer defineModulesWithOneLoader(Configuration cf, ClassLoader parentLoader)

      states: "IllegalArgumentException - If the parent of the given configuration is not the configuration for this layer”

      It might be that the given configuration has several parents, so “the parent” might sound confusing.


      #2 Specification for the following static methods

      public static ModuleLayer.Controller defineModulesXXX(...)

      states: “IllegalArgumentException - If the parent configurations do not match the configuration of the parent layers, including order”

      This could also look confusing since the parent configurations are not explicitly passed to the method.

      It might be better to use "If the parents of the given configuration”

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alanb Alan Bateman
                Reporter:
                dbessono Dmitry Bessonov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: