Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8187366

Remove hardcoded MSVC Version in win.gradle

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8u151, 9.0.1, 10
    • Fix Version/s: 10
    • Component/s: javafx
    • Labels:

      Backports

        Description

        Currently we hardcoded "14.10.25017" to extract the msvcBInDir. When i installed the MSVC 2017 pro update, the version changed to "14.11.25503".
        When i clean build and tried to compile with new version (14.11.25503), im getting below error.

        Execution failed for task ':graphics:linkWinIio'.
        > A problem occurred starting process 'command 'C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/link.exe''

        To proceed compilation, I manually edited below code in win.gradle from 25017 to 25503. I feel it is better to avoid hardcoded values in win.gradle.


        def msvcBinDir = ""
        if (winVsVer == 150) {
            msvcBinDir = (IS_64
                      ? "$WINDOWS_VS_VSINSTALLDIR/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64"
                     : "$WINDOWS_VS_VSINSTALLDIR/VC/Tools/MSVC/14.10.25017/bin/HostX86/x86")
           } else if (winVsVer <= 120) {
                      msvcBinDir = (IS_64
                                ? "$WINDOWS_VS_VSINSTALLDIR/VC/BIN/amd64"
                               : "$WINDOWS_VS_VSINSTALLDIR/VC/BIN")

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  mbilla Murali Billa
                  Reporter:
                  mbilla Murali Billa
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: