Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8187822

C2 conditonal move optimization might create broken graph

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 8, 9, 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b31

      Backports

        Description

        Attached test case fails with:

        # Internal Error (/home/rwestrel/aarch64-jdk8u-shenandoah/hotspot/src/share/vm/opto/loopnode.cpp:3579), pid=6922, tid=0x00007f4472cc4700
        # assert(false) failed: Bad graph detected in build_loop_late

        PhaseIdealLoop::conditional_move() creates a CMoveI node, updates the control of its inputs but not of a dependent data node. A following split thru phi leads to a broken graph.

          Activity

          Hide
          rraghavan Rahul Raghavan added a comment -
          initial ILW = HMM = P2
            I = crash, assert failure - bad graph detected;
            L = with c2, conditional_move optimizations, rare cases!;
            W = disable optimization - UseCMoveUnconditionally!
          Show
          rraghavan Rahul Raghavan added a comment - initial ILW = HMM = P2   I = crash, assert failure - bad graph detected;   L = with c2, conditional_move optimizations, rare cases!;   W = disable optimization - UseCMoveUnconditionally!
          Show
          kvn Vladimir Kozlov added a comment - Tested changes: http://cr.openjdk.java.net/~roland/8187822/changeset
          Hide
          kvn Vladimir Kozlov added a comment -
          Changes are pushed but for some reasons bug is not updated:
          http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2
          Show
          kvn Vladimir Kozlov added a comment - Changes are pushed but for some reasons bug is not updated: http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2
          Hide
          kvn Vladimir Kozlov added a comment -
          Changeset: b3fd664e5af2
          Author: roland
          Date: 2017-09-27 16:17 +0200
          URL: http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2
          Show
          kvn Vladimir Kozlov added a comment - Changeset: b3fd664e5af2 Author: roland Date: 2017-09-27 16:17 +0200 URL: http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2
          User: kvn
          Date: 2017-10-05 02:26:25 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/hs/rev/b3fd664e5af2 User: kvn Date: 2017-10-05 02:26:25 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk10/master/rev/b3fd664e5af2
          User: jwilhelm
          Date: 2017-11-04 02:58:06 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk10/master/rev/b3fd664e5af2 User: jwilhelm Date: 2017-11-04 02:58:06 +0000

            People

            • Assignee:
              roland Roland Westrelin
              Reporter:
              roland Roland Westrelin
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: