Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8190214

Reconcile jvm.h and all jvm_md.h between java.base and hotspot

    Details

    • Type: CSR
    • Status: Closed
    • Priority: P3
    • Resolution: Withdrawn
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Compatibility Risk:
      minimal
    • Interface Kind:
      Other
    • Scope:
      JDK

      Description

      Summary

      Unify jvm.h and os dependent versions of jvm_md.h between java.base and Hotspot versions, resulting in minor changes to the java.base versions.

      Problem

      Longstanding duplicate copies have diverged over the years, so there are minor differences resolving them. Mostly deletion of windows JVM functions that haven't been used since before JDK6, and some #defines. Also made visibility changes to jio_snprintf and similar functions for windows.

      Solution

      http://cr.openjdk.java.net/~coleenp/8189610.01/webrev/src/java.base/share/native/include/jvm.h.udiff.html

      Changes visibility of jio_*printf functions to JNIEXPORT.

      http://cr.openjdk.java.net/~coleenp/8189610.01/webrev/src/java.base/unix/native/include/jvm_md.h.udiff.html

      Added 1 to JVM_MAXPATHNAMELEN, removed JVM_O_READONLY defines - probably left over from when JVM did file io, added some signal #defines and added:

      #define JVM_ONLOAD_SYMBOLS      {"JVM_OnLoad"}
      #define AGENT_ONLOAD_SYMBOLS    {"Agent_OnLoad"}
      #define AGENT_ONUNLOAD_SYMBOLS  {"Agent_OnUnload"}
      #define AGENT_ONATTACH_SYMBOLS  {"Agent_OnAttach"}

      http://cr.openjdk.java.net/~coleenp/8189610.01/webrev/src/java.base/windows/native/include/jvm_md.h.udiff.html

      Same changes as unix, but also removed these declarations. Could not find any use of these in any repositories back to JDK6.

      JNIEXPORT struct protoent* JNICALL JVM_GetProtoByName(char* name);
      JNIEXPORT struct hostent* JNICALL JVM_GetHostByAddr(const char* name, int len, int type);
      JNIEXPORT struct hostent* JNICALL JVM_GetHostByName(char* name);

      http://cr.openjdk.java.net/~coleenp/8189610.01/webrev/src/java.base/macosx/native/include/jvm_md.h-.html

      Removed.

      Specification

      http://cr.openjdk.java.net/~coleenp/8189610.01/webrev/index.html

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                coleenp Coleen Phillimore
                Reporter:
                ihse Magnus Ihse Bursie
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: