Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8191129

AARCH64: Invalid value passed to critical JNI function

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 10
    • Fix Version/s: 10
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b36
    • CPU:
      aarch64
    • OS:
      linux

      Description

      compiler.runtime.criticalnatives.argumentcorruption.CheckLongArgs fails on AArch64.
      At first sight the fix from JDK-8167409 looks fine but it actually VM actually crashes with

      # Internal Error (/export/dchuyko/hs10/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1130), pid=28285, tid=28327
      # Error: Unimplemented()

      Which is SharedRuntime::check_needs_gc_for_critical_native() called from generate_native_wrapper().

      CriticalJNI support is at the time implemented in AArch64 port just partially. It will require unpack_array_argument() and generally some save_or_restore_arguments().

      For 10 scope I'd propose to do 2 things (both):
      1. Adopt original fix for incomplete implementation.
      2. Set CriticalJNINatives to false on AArch64.

      The latter will allow the test to pass in default configuration. There should be no performance hit currently because critical natives are only used by OracleUcrypto provider on Solaris.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dchuyko Dmitry Chuyko
                Reporter:
                dchuyko Dmitry Chuyko
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: