Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8191855

VirtualContainerBase: createVirtualFlow must be protected

    Details

    • Type: CSR
    • Status: Closed
    • Priority: P3
    • Resolution: Approved
    • Fix Version/s: 10
    • Component/s: javafx
    • Labels:
      None
    • Subcomponent:
    • Compatibility Risk:
      minimal
    • Interface Kind:
      Java API
    • Scope:
      JDK

      Description

      Summary

      API visibility change is done to facilitate custom VirtualFlow creation in JavaFX skin classes.

      Problem

      It is impossible to provide a custom VirtualFlow in JavaFX skin classes in JDK 9. On pulling VirtualContainerBase class into public scope in JDK 9, createVirtualFlow() method changed visibility from protected to package-private, thus fighting Its own api intent.

      Solution

      Following methods in VirtualContainerBase class are made protected to allow custom VirtualFlow creation in JavaFX skin classes - 1. createVirtualFlow() 2. getVirtualFlow()

      Specification

          /**
           * Create the virtualized container that handles the layout and scrolling of
           * all the cells. This enables skin subclasses to provide 
           * a custom {@link VirtualFlow} implementation.
           * If not overridden, this method intantiates a default VirtualFlow instance.
           * @return newly created VirtualFlow instance
           * @since 10
           */
          protected VirtualFlow<I> createVirtualFlow() {...}
      
      
          /**
           * Get the virtualized container.
           * Subclasses can invoke this method to get the VirtualFlow instance.
           * @return the virtualized container
           * @since 10
           */
          protected final VirtualFlow<I> getVirtualFlow() {...}

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                aghaisas Ajit Ghaisas
                Reporter:
                fastegal Jeanette Winzenburg
                Reviewed By:
                Kevin Rushforth, Philip Race
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: