Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8191995

Regression: DatePicker must commit on focusLost

    XMLWordPrintable

    Details

      Description

      had been fixed in JDK-8136838 and broken with fixing JDK-8150946

      The technical reason is the change in ComboBoxPopupControl in the latter, which removes the code that had been added in the former:

      +++ b/modules/controls/src/main/java/javafx/scene/control/skin/ComboBoxPopupControl.java Fri Jun 17 12:47:34 2016 +1200

      @@ -138,11 +138,6 @@

                   if (getEditor() != null) {

                       // Fix for the regression noted in a comment in RT-29885.

                       ((FakeFocusTextField)textField).setFakeFocus(hasFocus);

      -

      - // JDK-8120120 (aka RT-21454) and JDK-8136838

      - if (!hasFocus) {

      - setTextFromTextFieldIntoComboBoxValue();

      - }

                   }

               });

      The deeper reason is the oversight to not add commit/cancel semantics to the DatePicker - had not explicitly been mentioned in JDK-8150946 ...

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              aghaisas Ajit Ghaisas
              Reporter:
              fastegal Jeanette Winzenburg
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: