Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8193497

SA: Modify ClhsdbLauncher and other tests to throw errors on attach failures

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3
    • Resolution: Duplicate
    • Affects Version/s: 10
    • Fix Version/s: 13
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      The SA tests currently 'PASS' even though the test is 'skipped' due to attach permission issues. The SA tests execute the following snippet: (either directly in the test or indirectly through ClhsdbLauncher.java).

              if (!Platform.shouldSAAttach()) {
                  // Silently skip the test if we don't have enough permissions to attach
                  System.out.println("SA attach not expected to work - test skipped.");
                  return null;
              }
      The tests have to be modified to throw an error (and not PASS) if there is an attach failure. Once this is done, the tests which consume the output from ClhsdbLauncher for further testing, should throw an exception if there is any null output from ClhsdbLauncher. It would make sense to do this in the caller of ClhsdbLauncher.run() since this would be test specific.

      At this point, the SA Mach5 tests on MacOS do not run (due to attach permission issues) since they are not invoked with root privileges due to an infra issue. (INFRA-12468)

      So, due to the above issue, the SA tests on MacOSX would also have to be quarantined as a part of this fix till INFRA-12468 gets resolved.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jgeorge Jini George (Inactive)
                Reporter:
                jgeorge Jini George (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: