Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8195588

AArch64: Codegen fix after JDK-8194256

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 11
    • Fix Version/s: 11
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b01
    • CPU:
      aarch64
    • OS:
      linux

      Description

      JDK-8194256 updated the assembly logic, but forgot to update codegen part. Without JDK-8194256, the original assembler does not encode shift imm correctly as common sense, it required users (E.g. codegen) to encode the imm first and then feed to assembler to generate the correct shift imm encoding. JDK-8194256 updated the assembler implementation to hide the whole shift encoding inside assembler, but it forgot to update the codegen, which uses old assembly logic. Without codegen update, hotspot jtreg tests [1] failed.

      Attached simple patch should fix those failures.

      [1] Failed tests:
      compiler/c2/cr6340864/TestByteVect.java
      compiler/c2/cr6340864/TestIntVect.java
      compiler/c2/cr6340864/TestLongVect.java
      compiler/c2/cr6340864/TestShortVect.java
      compiler/codegen/Test6896617.java

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                njian Ningsheng Jian
                Reporter:
                njian Ningsheng Jian
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: